search

ncolomer / elasticsearch-osmosis-plugin

An Osmosis plugin that index OpenStreetMap data into elasticsearch
Apache License 2.0
101 stars 34 forks source link

Upgrade to elasticsearch 1.4.1 #21

Closed milovanderlinden closed 9 years ago

milovanderlinden commented 9 years ago

This pull request contains everything to upgrade to 1.4.1. Please feel free to adopt it into master or create a new 1.4.1 branch.

Kind regards, Milo van der Linden

ncolomer commented 9 years ago

Great work and big thanks @milovanderlinden! I'll add some pointers to the README.md, merge into a 1.4.x-tmp branch (as you know I'm working on a full revamp) and generate a release.

ncolomer commented 9 years ago

By any chance, have you tested it on elasticsearch releases 1.x and more? If I remember correctly, the client protocol is (retro-)compatible starting from release 1.0.0.

milovanderlinden commented 9 years ago

Thanks @ncolomer, I appreciate your effort. When the full revamp comes along, I will step back in. I am really interested in adding some extra mappings for addresses that, in the near future, could offer the same functionality as nominatim, but in elasticsearch.

milovanderlinden commented 9 years ago

No, but that shouldn't be so hard. If I can find some time later this week, I will build and test against 1.x versions by altering the pom, running tests, altering pom, running tests and so on.

2014-12-07 12:03 GMT+01:00 Nicolas Colomer notifications@github.com:

By any chance, have you tested it on elasticsearch releases 1.x and more? If I remember correctly, the client protocol is (retro-)compatible starting from release 1.0.0.

— Reply to this email directly or view it on GitHub https://github.com/ncolomer/elasticsearch-osmosis-plugin/pull/21#issuecomment-65933633 .

ncolomer commented 9 years ago

Merged onto branch 1.4.x-tmp and plugin version 1.4.0 released! I updated README.md to reflect this (+ plugged some CI).

Thanks again @milovanderlinden :)

Edit: just noticed the numerous commits that was added to this branch... was not intended, definitely not!