ncorbuk / SubZone

SubZone - Subdomains, Dns records, & more! || Python tutorial || Certificate authority abuse || Adavnced || Hacking/Info-Sec ||
MIT License
43 stars 12 forks source link

Use `sys.exit` instead of `exit` #10

Closed 42B closed 5 years ago

42B commented 5 years ago

https://github.com/ncorbuk/SubZone/blob/71dfa0e6b6bfd143a848387d937f4d0d61aec94f/subzone.py#L125

The site module (which is imported automatically during startup, except if the -S command-line option is given) adds several constants to the built-in namespace. They are useful for the interactive interpreter shell and should not be used in programs.

ncorbuk commented 5 years ago

Yep thanks changed it now

42B commented 5 years ago

You should really work on writing proper commit messages. Using the same phrase over and over is not descriptive at all.

Plus, you can close these issues automatically as part of the commit message instead of always having to manually do it.