ncoronado / tracshell

Automatically exported from code.google.com/p/tracshell
1 stars 0 forks source link

Write a code convention wiki page #36

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Without conventions, there is chaos. Moreover, I disagree with some coding 
practices in this project 
(especially this seemingly new trend of enforcing read-only on *private* 
variables in 
backends.trac.Ticket.__init__. that is unpythonic), so I think that these 
conventions should be clear 
(and more importantly, having been discussed).

Also, do you get notifications when I do code reviews? I made some in r49 and 
r34 but I never got 
any feedback from them.

Original issue reported on code.google.com by hsoft@hardcoded.net on 17 Apr 2009 at 7:36

GoogleCodeExporter commented 8 years ago

Original comment by hsoft@hardcoded.net on 17 Apr 2009 at 7:42

GoogleCodeExporter commented 8 years ago
i don't think i have been getting those reviews. odd.

what's so "unpythonic" about the property() decorator?

it has a very practical use in this case.

as far as coding conventions go, i'm open to your ideas as always. i usually 
just
stick to PEP 8.

wish googlecode had mailing lists for projects. or discussion forums or 
something.

either way, a more fluid channel of comms wouldn't hurt; especially for bigger
changes like the last one.

Original comment by j.kennet...@gmail.com on 17 Apr 2009 at 1:35

GoogleCodeExporter commented 8 years ago
It's not the property that I find unpythonic, it's this whole dict_to_tuple() 
scheme.

Original comment by hsoft@hardcoded.net on 18 Apr 2009 at 8:06

GoogleCodeExporter commented 8 years ago
no problem.. if you're open to it, you can start us off with a wiki page. :)

Original comment by j.kennet...@gmail.com on 1 May 2009 at 1:38