ncoronado / tracshell

Automatically exported from code.google.com/p/tracshell
1 stars 0 forks source link

Quote passwords in case they contain ? #39

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Set up a trac user that contains a ? in their password
2. Try and use tracshell with that password configured

What is the expected output? What do you see instead?
Expected successful start - got error with port not being an int, because
the urllib splithost function returns the username:password-until-? instead
(seeing the ? in the password as the end of the host part)

What version of the product are you using? On what operating system?
Latest trunk (r63) on Python 2.6 on Ubuntu 9.04

Please provide any additional information below.
Will attach patch that fixes this

Original issue reported on code.google.com by dav...@j5int.com on 8 Oct 2009 at 7:29

GoogleCodeExporter commented 8 years ago

Original comment by dav...@j5int.com on 8 Oct 2009 at 7:30

Attachments:

GoogleCodeExporter commented 8 years ago
Excellent. Thanks for the patch. I'll add it in.

Original comment by j.kennet...@gmail.com on 17 Sep 2010 at 6:53

GoogleCodeExporter commented 8 years ago
Added

Original comment by j.kennet...@gmail.com on 17 Sep 2010 at 6:59