search

ncr / rack-proxy

A request/response rewriting HTTP proxy. A Rack app.
MIT License
269 stars 94 forks source link

Allow SSL for non-streaming requests #24

Closed tdg5 closed 10 years ago

tdg5 commented 10 years ago

A minor change to allow using HTTPS/SSL for non-streaming requests.

I started to write a test, but I wasn't sure what would be a good HTTPS address to test against. I tried www.trix.pl, but there were some certificate issues that prevented a test against that domain from passing.

I manually tested the change against an in house HTTPS server and there were no issues in ruby-1.9.3-p448 or ruby-2.0.0-p247 running on Ubuntu 12.04.

If you have a domain suggestion, I'd be happy to write a test.

Also, if you prefer I refactor the code to check for SSL in only one place, I can do that too.

ncr commented 10 years ago

Hi Danny! I think https://apple.com might be a "stable" domain for testing :) The refactoring you mentioned would also be most welcome. I'll merge this right away, the test and refactoring can come in another PR. Thanks a lot!