search

ncr / rack-proxy

A request/response rewriting HTTP proxy. A Rack app.
MIT License
269 stars 94 forks source link

Check body for nil #34

Closed nhemsley closed 10 years ago

nhemsley commented 10 years ago

This checks the body of a proxied response for nil & sets it to [""] if so.

Otherwise you get 'no implicit conversion of nil into String' from somewhere in Rack

nhemsley commented 10 years ago

Oops, the only commit that matters to this is 'check body for nil/false'.

Sorry it's getting late, lots of debugging rack for the first time.

I can re-submit this if it is no good.

Cheers

ncr commented 10 years ago

I'll merge this tomorrow, thank you!

nhemsley commented 10 years ago

This PR is broke. I have reopened here https://github.com/ncr/rack-proxy/pull/38