search

ncroxon / gnu-efi

Develop EFI applications for ARM-64, ARM-32, x86_64, IA-64 (IPF), IA-32 (x86), and MIPS platforms using the GNU toolchain and the EFI development environment.
GNU General Public License v2.0
49 stars 11 forks source link

Fix driver EFI subsystem for VS and RISCV64 and add driver testing #31

Closed pbatard closed 5 months ago

pbatard commented 5 months ago

This series of patches aims at adding driver testing to our test suite.

To accomplish that, we need to fix the subsystem that was improperly set for the Visual Studio driver, as well as fix subsystem generation for RISCV64, which was broken per #27.

To accomplish the latter, we simply set the subsystem using dd after the objcopy step (which is made a little more complex due to the fact that GNU Make's echo doesn't support -ne but still relatively straightforward).

With these patches, we can then add a new test that validates that drv0 loads and can be invoked.

gmbr3 commented 5 months ago

Overall, best way to go Also PR text doesn't contain the word closes next to the bug ref so GitHub hasn't detected it'll close an issue

pbatard commented 5 months ago

Okay, I removed the extra step from %.efi.debug.

As to getting #27 to be closed automatically, I believe the 2nd commit should do that once it is applied to the main repo by Nigel (as I think it's better to have the issue closed by the commit that fixed it than a PR patchset with multiple commits, including unrelated ones).