Closed evacchi closed 1 year ago
This broke dcraw
, again. I'll look into it.
Need to split it off into a module with its own integration tests.
let me know how I can assist, what errors are you seeing?
Thanks! No error messages. Simply, no thumbnails get extracted.
I'm pretty sure it's going to be because of changes to WASI, and/or WASI libc, that my custom FS doesn't like.
But it passes fstest.TestFS
now, so we'll see. It's a useful component, still, I think (it sandboxes dcraw to only be able to read that one file).
Don't worry. It'll be a fun debugging session. I'm sure it's my problem to fix.
can you check if it's related to this? https://github.com/tetratelabs/wazero/pull/1182 in that case the workaround is easy, just check if fsconfig is nil and avoid passing it in that case (or pass a meaningful value instead)
It was my issue all along! Hopefully, this time I'm covering all corner cases for fs.FS
.
This updates wazero to 1.0.0-rc.1. This version does not change any public API, but it delivers several bug fixes and improvements; including
Signed-off-by: Edoardo Vacchi evacchi@users.noreply.github.com