search

ncs-jss / HTTP_200

JSS InfoConnect Web Application
http://210.212.85.155:8082
28 stars 27 forks source link

Fixed #192 #196 #222

Closed singhsterabhi closed 7 years ago

singhsterabhi commented 7 years ago

fixed #192 fixed #196

RishabhJain2018 commented 7 years ago

Moreover, please update your review comment by using these guidelines https://help.github.com/articles/closing-issues-using-keywords/

RishabhJain2018 commented 7 years ago

@singhsterabhi The code looks good to me. Can you please paste the screenshot for before and after the change.

singhsterabhi commented 7 years ago

wifi form before: after: screenshot from 2017-09-12 18-12-14 Similarly on pages index, about, contact, profile,etc.

RishabhJain2018 commented 7 years ago

@singhsterabhi Can you please open a new PR for #196 . It would make the code more modular.

RishabhJain2018 commented 7 years ago

@singhsterabhi Please let me know if you are facing any problem. I will be glad to help you!

RishabhJain2018 commented 7 years ago

@singhsterabhi let's discuss it tomorrow and get it merged :)

singhsterabhi commented 7 years ago

Created new pr #226