search

ncs-jss / HTTP_200

JSS InfoConnect Web Application
http://210.212.85.155:8082
28 stars 27 forks source link

Notice admin updated #225

Open dhruvhacks opened 7 years ago

dhruvhacks commented 7 years ago

Following PR fixes #52 and fixes #170 Notices bookmarked by users are listed at end of that specific notice now. Admin Interface notice_admin

displaying bookmarked notice section at the end of edit notice menu bookmarked_notice_view

RishabhJain2018 commented 7 years ago

@dhruvhacks Can you please resolve the conflicts.

dhruvhacks commented 7 years ago

@RishabhJain2018 Merge conflicts resolved and build failures fixed. Please review the PR.

dhruvhacks commented 7 years ago

@RishabhJain2018 All the requested changes have been reverted. Please review the PR.

dhruvhacks commented 7 years ago

@RishabhJain2018 changes updated, Please review the PR. :slightly_smiling_face:

RishabhJain2018 commented 7 years ago

Hey @dhruvhacks I checked it and found that it would not be a good way of displaying it, once the list populates with large number of users. Currently, we can add searching the Bookmarks admin. Let me know your thoughts over it.

RishabhJain2018 commented 6 years ago

@dhruvhacks Any update on this??

dhruvhacks commented 6 years ago

Currently, we can add searching the Bookmarks admin. Let me know your thoughts over it.

@RishabhJain2018 Sir, I felt that having separate admin display for bookmarked notices would be vague since all the notices and users will be mixed within one. This PR appends a section for Bookmarked notice within the notice admin since all the users will be grouped together under a specific notice and it would be easier to access.

I checked it and found that it would not be a good way of displaying it, once the list populates with large number of users.

We may set a limit (say 10) for no. of users to be displayed who bookmarked the specific notice. Currently admin.TabularInline method does not provide any scope for adding search bar due to it's display layouts. Moreover in case of such InlineModelAdmin, possible filter methods include filter_vertical (link) but it also requires a ManyToMany field and notices.users is a ForeignKey field.

Sorry for the late reply.

RishabhJain2018 commented 4 years ago

@dhruvhacks Feel free to merge this as well.

dhruvhacks commented 4 years ago

@RishabhJain2018 Okay sir. Will update the PR and consider merging!