search

ncs-jss / hackncs-17

Official website Of NCS
http://hack-ncs.surge.sh/
3 stars 6 forks source link

Scrolling issue in events page #17

Closed abhayraw1 closed 7 years ago

abhayraw1 commented 7 years ago

After clicking on an event the pop up (or whatever...) doesn't scroll. On scrolling the background appears to be scrolling instead of the popup.

DEVAbhinav commented 7 years ago

@itaditya see if the popup really needs a vertical scrollbar because its a poster of fixed dimensions.

itaditya commented 7 years ago

Actually Sir ,the poster was a little reduntant in the modal , so I think we should not show it in the modal .

The other work around is that I keep the height of poster fixed and width be automatic , If you are free , I can come and show you that now. and also integrate backend ,

And what you mentioned is not the case as we will have different images for different events of different sizes

itaditya commented 7 years ago

It seems this is an issue with the one page scroll plugin itself (https://github.com/peachananr/onepage-scroll/issues/229) , I tried every viable option but there is only one workaround which is to prevent the popup from overflowing (thereby no need for scroll) ,

DEVAbhinav commented 7 years ago

This looks good now !! More suggestion from @sidjain2901 sir expected!