search

ncs-jss / plexus

MIT License
2 stars 7 forks source link

Fix code sniffer errors #5

Closed christophherr closed 7 years ago

christophherr commented 7 years ago

Warnings about "Line exceeding 85 characters" are still being shown. Related issue: #4

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 2.268% when pulling 3b4b8191638993e46fabd9af1027e6b00d0b14ee on christophherr:master into 343fc919f90201bc1461cb0f735a03a653ee9816 on ncs-jss:master.

christophherr commented 7 years ago

The three options would be to try to reduce the characters per line, exclude the line length rule or add your own line length standard.

ankitjain28may commented 7 years ago

@christophherr It can also be fixed like you can break line from commas or you can use . to concat a large statement by breaking it into smaller sub strings.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.02%) to 2.248% when pulling 7f9be90f12d318e3869b9cac6d37b3eda18eb8b2 on christophherr:master into 343fc919f90201bc1461cb0f735a03a653ee9816 on ncs-jss:master.

christophherr commented 7 years ago

@ankitjain28may No problem. Just wanted to know how you want to handle it. Of course, now that there are more lines, the coverage has decreased and that fails the build...

ankitjain28may commented 7 years ago

@christophherr No problem, Thanks for fixing this, Would you like to write the tests for the project ?

christophherr commented 7 years ago

@ankitjain28may Thanks. I'll see if I can add some tests.

ankitjain28may commented 7 years ago

@christophherr You can use Laravel/dusk to write tests for the project.