ncsa / puppet-profile_update_os

NCSA Common Puppet Profiles - configure functionality for upgrading OS packages
0 stars 0 forks source link

Use yum::yumconfig for managing yum configuration #3

Closed andylytical closed 3 years ago

andylytical commented 3 years ago

https://github.com/ncsa/puppet-profile_update_os/blob/1ddf82231503dd7ad829264925a8b05ac1279201/manifests/yum_upgrade.pp#L75-L109

Manipulating config files should be a last resort.

andylytical commented 3 years ago

Note also that puppet-yum expects to manage installonly_limit by default. Suggest the parameter should be removed from this profile and allowed to be set via hiera settings directly for puppet-yum. This cleans up the profile and allows the default setting from puppet-yum to be used, which happens to match the default settings we already want.

billglick commented 3 years ago

7 breaks if using puppet/yum yum::config to set package excludes with wildcards, so cannot currently use yum::config to set the package excludes.