ncsco / pinemap-dss-help

Issue tracker for PINEMAP DSS
0 stars 0 forks source link

Seedling Deployment Tools: Map Display Bugs #42

Closed hadinon closed 8 years ago

hadinon commented 8 years ago

After the changes were made to the layout of the Map Display options (horizontal layout instead of vertical, see issue #37 ) , I noticed a few bugs with the seedling deployment tools...

1) After initially selecting your location by clicking on the historical map, I tried toggling back to the historical map by clicking the radio button under Map Display. However, the historical map is not returned. This is the result:

image

2) Starting from where I left off in step 1, if I then hit "Show 5 degree range" for 2020-2039 and finally click the "Projected Temperatures" radio button under Map Display, something really weird happens with the isotherms (it looks like the 5 degree range is being overlaid with all of the other projection layers):

image

Are you able to replicate?

daviswx commented 8 years ago

Yes, I was able to replicate it, and it should be fixed now. It was caused by a JavaScript error related to a change I made earlier today.

hadinon commented 8 years ago

While double checking to make sure #9 was fixed, I found two issues (shown below) with the Dynamic Hardiness Zone tools although I'm not entirely sure these issues are related to #9. Here's my process for obtaining these bugs:

Bug 1: Select a location somewhere in the ocean (I could see someone accidentally doing this). The message pops up indicating that projected data is unavailable for your selected location but the selected radio button becomes the "Location-Specific Ranges" one yet the data being displayed is the Historical Average map. image

Bug 2: Select a location somewhere over land and when the "Location-Specific Ranges" display shows up, click "Show all time periods". Then, click somewhere in the ocean (again, I could see someone accidentally doing this). Again, the message pops up about projected data being unavailable at that location but the isotherm layers remain "turned on". I thought we decided to keep it turned off in these cases but I could be remembering incorrectly.

image

daviswx commented 8 years ago

This issue got lost in the chaos a few weeks ago, but I just revisited it and I think it's fixed now. If a selected location is not valid, the Historical Temperatures display will show up.

I will close this issue in the next commit to the public DSS site.

hadinon commented 8 years ago

Yep, looks fixed to me so I'm closing it.