search

ncsco / pinemap-dss-help

Issue tracker for PINEMAP DSS
0 stars 0 forks source link

Search Box Feedback #82

Closed hadinon closed 8 years ago

hadinon commented 8 years ago

Comments from Tomasz Koralewski:

image

The drop-down menus show when mouse moves over but disappear when mouse moves down and cannot be clicked. The Search box remains underlined.

Note: this behavior occurs with Windows 7 Professional with Service Pack 1, Internet Explorer v. 11 I am not able to replicate using Chrome 48.0.2564.103 m or Firefox 43.0.1 with Windows 10.

daviswx commented 8 years ago

I am also able to replicate this on IE but not on Chrome and Firefox. It's not giving any errors in IE, but maybe that browser treats the menu navigation functions slightly differently. I will explore more...

daviswx commented 8 years ago

How to trigger the Submit button when 'Enter' is clicked: http://stackoverflow.com/questions/12955222/how-to-trigger-html-button-when-you-press-enter-in-textbox

daviswx commented 8 years ago

The search box will now submit when the Enter key is pressed.

The bug with the search results menu not hiding in IE should also be fixed. It required a bit of a workaround in my code, but it seems to be working correctly in all three browsers I tried.

hadinon commented 8 years ago

Great! The bug is fixed when I tested it with Edge, too. :+1:

daviswx commented 8 years ago

Still one bug with it: After searching, if you scroll over one of the other menu titles, they show up behind the search results. Could fix by changing the search results box z-index.

May also want to try putting the search results box in a different color.

Once this is fixed, turn off the search box and expand the other menu items horizontally.

daviswx commented 8 years ago

This bug should be fixed. Could you check on your end to confirm?

Once that's done, I will comment out the search box until we add more tools and want to put it back in.

hadinon commented 8 years ago

It seems to be working in Chrome but not in Firefox or Edge and I cleared my cache! Which browsers did you try it in?

It's also doing that weird thing with the text that we discussed at the eye tracking meeting. I think you said you changed it to clear on focus but I might be remembering the terminology wrong. Are you able to replicate?

daviswx commented 8 years ago

It was also working for me in Chrome but not in Firefox. Annoyingly, each browser handles some JQuery functions a bit differently, which is the cause of this bug and the previous one Tomasz mentioned.

I made some changes and it's working for me now in Chrome, Firefox, and IE. Could you check all the browsers on your end and make sure it's working in them?

Also, which text box is doing weird things for you? Is it the search box? Because it is set to clear the filler text on focus -- in fact, the search box always has been that way -- and I'm not able to replicate the problem with entering text mid-string in any browsers. After our meeting last week, I changed the lat/lon boxes to also use that function, so you may want to check them as well.

hadinon commented 8 years ago

OK, it looks to work across all browsers now. :+1:

Turns out the weird text box issue is only occurring with my rather buggy desktop version of IE so that's probably an IE issue not a DSS issue.

daviswx commented 8 years ago

Now that the bugs seem to be fixed, I have turned off the search box and enlarged the other menu items. The search box can easily be re-enabled once we add more tools.