search

ncss-2014-group-3 / word-by-word

Group 3's word at a time social network
7 stars 4 forks source link

Upvoting whilst logged out requires better error message #7

Open sysr-q opened 10 years ago

sysr-q commented 10 years ago

At the moment it's "You must be logged in to post a word", which doesn't really make sense in the context of voting. Would not understand/10.

nhardy commented 10 years ago

I think I may have partially fixed that in one of my commits. It doesn't give any error at all for me.

nhardy commented 10 years ago

I could just make it so if the user is not logged in the up vote button is disabled, or perhaps remove the entire box?

sysr-q commented 10 years ago

It'd make sense to still have the button - disabling it may be an option, but at the very least a good error message is required. This sort of ties in #3, since if we're working on vote-button design/functionality, might make sense to work out how to make it better on mobile devices.

nhardy commented 10 years ago

I've implemented disabling of the button in #42 and it seems to work Ok. The popup just disappears when the upvote button is hovered on (some property of disabled buttons?). Probably not the best solution though. Maybe an onhover/onclick event triggering alert?