Fixes for #35 - Githubissues

ncss-tech / SoilKnowledgeBase

Unified descriptions and structures for USDA-NRCS / National Cooperative Soil Survey / Soil and Plant Science Division standards.

https://ncss-tech.github.io/SoilKnowledgeBase/

7 stars 1 forks source link

Fixes for #35 #36

Closed brownag closed 3 years ago

brownag commented 3 years ago

PR for testing fixes for #35

Fix bug in drainage class parsing (bad list item name, handling of >1 class (takes first non-NA value).
- Combinations like "well to moderately well drained" will only return one class (i.e. "well")

Address this in next PR: ~- Use "" as a JSON-compatible NA placeholder ~ ~ - This could be a different value and could be reversed by soilDB::get_OSD() to return NA as appropriate~

brownag commented 3 years ago

There are now two drainage class fields in the SITE result: one parsed from standard "drainage and permeability" section and one from the "overview".

Most soils mention drainage in the overview and in the drainage section e.g. Musick

https://github.com/ncss-tech/SoilKnowledgeBase/blob/3865d63bb88e49e0cb682c76659f2fafc550b878/inst/extdata/OSD/M/MUSICK.json#L60-L67

Some soils have multiple / ranges of drainage classes

https://github.com/ncss-tech/SoilKnowledgeBase/blob/3865d63bb88e49e0cb682c76659f2fafc550b878/inst/extdata/OSD/A/ACADEMY.json#L60-L67

Some soils describe classes that differ between the overview and the drainage section. These should be reviewed.

https://github.com/ncss-tech/SoilKnowledgeBase/blob/3865d63bb88e49e0cb682c76659f2fafc550b878/inst/extdata/OSD/A/ADAMS.json#L60-L67

Rarely, some soils only have drainage in the overview. I think this is an error.

https://github.com/ncss-tech/SoilKnowledgeBase/blob/3865d63bb88e49e0cb682c76659f2fafc550b878/inst/extdata/OSD/B/BORDENGULCH.json#L60-L67