Testing new aqp::col2Munsell() replacing aqp::rgb2munsell()

ncss-tech / soilDB

soilDB: Simplified Access to National Cooperative Soil Survey Databases

http://ncss-tech.github.io/soilDB/

79 stars 19 forks source link

Testing new aqp::col2Munsell() replacing aqp::rgb2munsell() #325

Closed dylanbeaudette closed 7 months ago

dylanbeaudette commented 7 months ago

Want to make sure there are no unexpected results. Related to https://github.com/ncss-tech/aqp/issues/297

brownag commented 7 months ago

Thanks for making these changes. I've tested them locally with the "run all NASIS get-methods" script, no errors encountered.

Also updated the CI which was not properly loading the soilDBdata package for the extended tests--for some reason those are still getting skipped by the R CMD check action but I will deal with that later. PR looks good to merge

dylanbeaudette commented 7 months ago

Great thanks.