search

ncssar / sartopo_python

Python calls for the caltopo / sartopo API
GNU General Public License v3.0
14 stars 2 forks source link

incomplete cut operation #24

Closed caver456 closed 3 years ago

caver456 commented 3 years ago

sometimes (not always) the cut operation appears to be incomplete or interrupted:

image

a10=sts.getFeatures(title='a10')[0] b10=sts.getFeatures(title='b10')[0] sts.cut(a10,b10)

image

this particular case is in the larger test case map where many geometry operations all take place and sync is happening at the default interval. Maybe the request timing is a problem - maybe a since request gets sent before a geom operation has completed, or maybe a geom operation request gets sent before the since response is received? Do we need to add some locking mechanism in sendRequest to prevent this? I thought REST requests guarded against this by nature? Should probably investigate, but, if the worst thing that happens is this one incomplete operation, then it's probably not high priority.

caver456 commented 3 years ago

note the correct output looks like this:

image

The problem above is that the a10 polygon is unmodified, though a10:1 is added correctly.

caver456 commented 3 years ago

this specific is fixed with #26 but may also be a symptom of #27