search

ncssar / sartopo_python

Python calls for the caltopo / sartopo API
GNU General Public License v3.0
14 stars 2 forks source link

CTD NPEs following 'RequestPropertyFilter handling uncaught exception' #35

Closed caver456 closed 2 years ago

caver456 commented 2 years ago

This was first noticed after DELETE requests - apparently a new exception and NPE came up with each DELETE request.

In the course of trying to debug the DELETE requests, noticed that the first NPE happens on the initial dummy-request during session startup, which was used to confirm the API version.

Turns out that all NPEs go away if you skip the initial dummy-request, and replace it with these hardcodes:

        # try these hardcodes, instead of the above dummy-request, to see if it avoids the NPE's
        self.apiVersion=1
        self.apiUrlMid="/api/v1/map/[MAPID]/"

This does kind of ring a bell, that Matt may have said a year or more ago that the dummy-request is no longer required.

Continue testing for a while with the hardcodes in place; if there are no ill effects, the dummy-request code should probably be eliminated.

caver456 commented 2 years ago

see #34 for the original DELETE request issue

caver456 commented 2 years ago

used the above hardcodes in recent commit; closing this issue for now; but #34 (slowness) is still open since it's not clear if the hardcodes are related to performance.