Fix #552: hack to prevent moodle_exception when called by defaultcompletion()

ncstate-delta / moodle-mod_zoom

Moodle plugin for Zoom meeting

61 stars 106 forks source link

Fix #552: hack to prevent moodle_exception when called by defaultcompletion() #553

Closed opitz closed 7 months ago

opitz commented 7 months ago

This will - somehow - fix #552. Since Moodle 4.3 defaultcompletion() will call all definition() instances from mod_form.php of installed modules. This has implications that have been addressed here. There might be better ways to deal with it...

jrchamp commented 7 months ago

Hi @opitz,

It looks like Moodle renamed a page and broke our previous hack for this issue #481: https://github.com/ncstate-delta/moodle-mod_zoom/blob/d4db341b3429c6f3cbd82a3454d852423b7b2d3d/mod_form.php#L51-L54

Try changing course-editdefaultcompletion to course-defaultcompletion and see if that fixes the issue. We'll still need to keep the "edit" version for backward compatibility until we can get a real fix. I've asked the Moodle team who worked on it for help.

smbader commented 7 months ago

Thank you @opitz,

So that we don't break our previous change, we're going to continue to expand our current method.

Thank you so much for working on this! Steve