search

ncstate-delta / moodle-mod_zoom

Moodle plugin for Zoom meeting
https://moodle.org/plugins/mod_zoom
61 stars 108 forks source link

issue #557: Add SVG and PNG icon for calendar #558

Closed ScottVerbeek closed 8 months ago

ScottVerbeek commented 9 months ago

Resolves issue #557 fixing unit test test_svg_fallback on Moodle 4.3.

root@c3e2c38a9c70:/var/www/vanilla-403# vendor/bin/phpunit --filter test_svg_fallback 
Moodle 4.3.2 (Build: 20231222), 6a6043c47b80ea6f64f69d8a41487ded3444a970
Php: 8.1.24, pgsql: 14.0 (Debian 14.0-1.pgdg110+1), OS: Linux 6.4.12-060412-generic x86_64
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

...............................................................  63 / 507 ( 12%)
............................................................... 126 / 507 ( 24%)
............................................................... 189 / 507 ( 37%)
............................................................... 252 / 507 ( 49%)
............................................................... 315 / 507 ( 62%)
............................................................... 378 / 507 ( 74%)
............................................................... 441 / 507 ( 86%)
............................................................... 504 / 507 ( 99%)
...                                                             507 / 507 (100%)

Time: 00:11.212, Memory: 344.00 MB

OK (507 tests, 507 assertions)

Fixes #557

jrchamp commented 9 months ago

Thanks @ScottVerbeek! We'll do some testing on our side and plan to merge this in the next release.

jrchamp commented 8 months ago

Hi @ScottVerbeek, I wasn't able to push directly to your branch, so I opened https://github.com/catalyst/moodle-mod_zoom/pull/1 to optimize the SVG files. With that change added on, I'd be happy to approve and merge this tomorrow.

smbader commented 8 months ago

@jrchamp will add SVGOMG optimizations in a separate pull request.