search

ncstate-delta / moodle-mod_zoom

Moodle plugin for Zoom meeting
https://moodle.org/plugins/mod_zoom
61 stars 106 forks source link

Sessions report doesn't have users that using the Moodle mobile app #564

Open bunkerskyi opened 6 months ago

bunkerskyi commented 6 months ago

Hello. We have problems, users who use the Moodle mobile app don't present in the Sessions report. I guess that happening because the join link in the mobile app doesn't have the uname parameter. Is that might be true?

I made this assumption, that the uname is critical, according to this comment and this PR

jrchamp commented 6 months ago

Thanks @bunkerskyi, we'll do some testing to see if we can reproduce the issue.

For any enterprising developer, here's the code flow:

Clicking the join meeting button in the Moodle Mobile app: https://github.com/ncstate-delta/moodle-mod_zoom/blob/54313db6f1f8c3ef1b350c1ffcad0a42c37f8123/templates/mobile_view_page_latest.mustache#L54

Calling the mod_zoom_grade_item_update function registered in services.php: https://github.com/ncstate-delta/moodle-mod_zoom/blob/54313db6f1f8c3ef1b350c1ffcad0a42c37f8123/db/services.php#L43-L46

An external function provides the same join URL for Mobile, so it should already have the uname specified: https://github.com/ncstate-delta/moodle-mod_zoom/blob/54313db6f1f8c3ef1b350c1ffcad0a42c37f8123/classes/external.php#L196-L203

If the registered function returns success, a new window is opened using the returned join URL: https://github.com/ncstate-delta/moodle-mod_zoom/blob/54313db6f1f8c3ef1b350c1ffcad0a42c37f8123/classes/output/mobile.php#L90

jrchamp commented 5 months ago

Thanks @sgrandh3 for taking a look at this.

bunkerskyi commented 5 months ago

@jrchamp Hello. I see more information needed badge on this issue. Please let me know if I can provide any additional info to speed up the process. We are very interested in solving this problem

jrchamp commented 5 months ago

Thanks @bunkerskyi! I'm not sure exactly which part is not working, so it would be very useful for us to understand where it is breaking. Any help you can provide would be significant:

  1. Are you able to reproduce the issue yourself?
  2. Specifically, can you install the Moodle mobile app and the Zoom mobile app and join a meeting that someone else creates in Moodle?
  3. If so, does your name in the Zoom meeting show your Moodle user's name or does it show something else?
  4. After the scheduled task that loads the data for the sessions report is complete, does the report have the name that showed in the meeting?
  5. Which version of the mod_zoom plugin, Moodle Mobile app and Zoom mobile app are you using?
sgrandh3 commented 4 months ago

When tested, by hosting a zoom meeting as an instructor, to a student who logged from only mobile (disconnected from the browser) , i got 2 records of the student. Did it multiple times, with the same result. Adding the session report for reference. zoom_participants_94832982546.xlsx