ncstate-delta / moodle-mod_zoom

Moodle plugin for Zoom meeting
https://moodle.org/plugins/mod_zoom
61 stars 106 forks source link

delete recordings: Only delete if API call succeeded #593

Closed jrchamp closed 2 months ago

jrchamp commented 2 months ago

Reviewer: ignoring spaces in the diff will save significant time.

Previously, if the API call failed due to network or rate-limiting issues, the delete recordings task would think that the recording had been deleted from Zoom (and the local entries in Moodle would also be deleted).

One potential concern: will the API return a "that Meeting UUID doesn't exist" error? If it did, then we wouldn't delete the recordings. Maybe we should check that they exist directly? At least now, we're failing into a safer stance.

Fixes #539 (hopefully!)