search

ncstate-delta / moodle-mod_zoom

Moodle plugin for Zoom meeting
https://moodle.org/plugins/mod_zoom
61 stars 108 forks source link

scheduled task "mod_zoom\task\get_meeting_recordings" fails with recordingtype "shared_screen_with_speaker_view'" #599

Closed samwitzig closed 2 months ago

samwitzig commented 3 months ago

We unfortunately have the scheduled task "mod_zoom\task\get_meeting_recordings" failing: If the recording type is "shared_screen_with_speaker_view", we receive the error "ERROR: value too long for type character varying(30)".

In the database scheme (https://github.com/ncstate-delta/moodle-mod_zoom/blob/main/db/install.xml -> line 127, we see that field recordingtype has 30 characters, "shared_screen_with_speaker_view" however has 31 characters.

jrchamp commented 3 months ago

Thanks @samwitzig! It looks like when we modified the data being stored in the field (2 months ago), we forgot to check the field's maximum size (last modified 3 years ago).

For the implementing developer, please make sure to use Moodle's built-in XMLDB Editor tool. We already know about a 35 character recording type, so maybe 50 would be a more comfortable limit.

acquaalta commented 2 months ago

Hi @jrchamp, Thanks for @samwitzig and you for explaining the nature of the bug. We also encountered it.

My follow-up question is: What if I already installed the "Zoom meeting" plugin which has this 30 characters limitation in the "recordingtype" field? The relevant table is already created in Moodle DB, with that limitation in the field. Is there a way to fix the issue locally before you'll release an updated plugin version with the fix? I assume, of course, that the fix would also help these already have a previously installed a version of the plugin that has this bug (like 5.2.2, the latest one).

Thanks

jrchamp commented 2 months ago

Hi @acquaalta,

Yes, the fix will change new installs and existing installs so that the column is large enough to store the expected values. If you want to fix it directly, you can, by increase the recordingtype column size.

samwitzig commented 2 months ago

Any chance this issue is fixed before August 7th/8th? The Moodle HQ will release the new Moodle minor versions on August 12th, after which a lot of Moodle admins will touch their systems anyway.

jrchamp commented 2 months ago

Personally, I'm hoping to have a release this week and this issue is the top priority for that release.