ncstate-sat / popover

Popover component for Angular
MIT License
225 stars 47 forks source link

Stackblitz demo seems broken #303

Open jordan-bamber opened 4 months ago

jordan-bamber commented 4 months ago

It just remains stuck on "Starting dev server"

wjaspers commented 4 months ago

Ah shoot. This likely happened during the upgrade to Angular 17 as the peerDependencies set to @angular/^17. Maybe @isaackehle can update it. Otherwise I'll try to get one in good shape this weekend.

isaackehle commented 4 months ago

I can’t this weekend but I can look at it on Monday.

-- Sent from Canary (https://canarymail.io)

On Saturday, Jun 29, 2024 at 8:16 PM, Will @. @.)> wrote:

Ah shoot. This likely happened during the upgrade to Angular 17 as the peerDependencies set to @angular/^17. Maybe @isaackehle (https://github.com/isaackehle) can update it. Otherwise I'll try to get one in good shape this weekend.

— Reply to this email directly, view it on GitHub (https://github.com/ncstate-sat/popover/issues/303#issuecomment-2198382330), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAGC2PZXS6BPJ7Y2XBNOOY3ZJ5E7PAVCNFSM6AAAAABKCEXG4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGM4DEMZTGA). You are receiving this because you were mentioned.Message ID: @.***>

wjaspers commented 4 months ago

Here is a minimally repaired version with Angular 18.

https://stackblitz.com/edit/ncstate-sat-popover-issues-hn7ljt