Use explicit cast for rounded numbers

ncsu-landscape-dynamics / pops-core

PoPS Core: C++ library for the Pest or Pathogen Spread Model

https://ncsu-landscape-dynamics.github.io/pops-core

GNU General Public License v2.0

5 stars 2 forks source link

Use explicit cast for rounded numbers #214

Closed wenzeslaus closed 6 months ago

wenzeslaus commented 7 months ago

Replace round by lround to create integer.
Add static cast to integer for results of existing calls of ceil.
Explicitly convert to bool using static cast in if-conditions.

These satisfy the -Wfloat-conversion GCC warning for these lines.

wenzeslaus commented 7 months ago

I ended up putting all the changes into one PR which made it easier to test and check the warning. I still may split that for an easier review, but the different types of changes are in separate commits.

wenzeslaus commented 6 months ago

This is now ready for review.

I split the PR into multiple PRs and then cleaned up this one. It should be easier to review this way. The other PRs are ready for review as well.