Use explicit floor or ceil for forceful int to double conversions

ncsu-landscape-dynamics / pops-core

PoPS Core: C++ library for the Pest or Pathogen Spread Model

https://ncsu-landscape-dynamics.github.io/pops-core

GNU General Public License v2.0

5 stars 2 forks source link

Use explicit floor or ceil for forceful int to double conversions #217

Closed wenzeslaus closed 6 months ago

wenzeslaus commented 6 months ago

Uses static_cast with floor for clear truncation cases (without subtraction).
Use static_cast with floor or ceil depending on the type of treatment based on the original code (in treatments and tests).

wenzeslaus commented 6 months ago

This does not change the results.

I still want to do the actual change to rounding in a different PR, but we can use this PR to discuss what change needs to be done or I can just prepare another one applying rounding everywhere and we would go from there.