search

ncsu-landscape-dynamics / rpops

PoPS (Pest or Pathogen Spread) R Package
https://ncsu-landscape-dynamics.github.io/rpops/
GNU General Public License v3.0
10 stars 5 forks source link

Better specs for terra version #101

Closed wenzeslaus closed 3 years ago

wenzeslaus commented 3 years ago

Problem description

I'm not sure how exactly the terra versions are numbered, but there is couple of commits in Git which have 1.1-7 in the DESCRIPTION file. Just any of them is not enough. The first commit rpops now works with is https://github.com/rspatial/terra/commit/cd4c35c7818adc26be896d65d130070843fb61c5.

Expected behavior, suggested solution

Notably, this will resolve itself over time (when the version we need is on CRAN) and I'm not sure what is the right for now.

The terra package is changing rapidly and we are currently using the development version from GitHub, so maybe using specific version in readme which is guaranteed to work?

devtools::install_github("rspatial/terra", ref="cd4c35c7818adc26be896d65d130070843fb61c5")

And/or using 1.1.8 (1.1-8) in DESCRIPTION file?

On the other hand, in the CI we are simply using the latest version/commit, so with active development in rpops (or a scheduled action we set up), we discover a potential incompatibility with terra here in the repo.

More info

Currently, you can get things like:

> devtools::load_all()
...
Warning message:
object ‘patches’ is not exported by 'namespace:terra' 
> packageVersion("terra")
[1] ‘1.1.7’
ChrisJones687 commented 3 years ago

Terra version 1.1.17 (1.1-17) is now avaliable on CRAN I will update the documentation to make this the minimum version. Using the latest available CRAN version will also fix the annoying install issue in #98.

wenzeslaus commented 3 years ago

Jst to understand that better, I tried to figure out from CRAN which commit it actually uses, but I don't see it. Assuming that it works and that transition to 1.1.18 will happen sooner rather than later, I would say we can close this.