search

ncsu-landscape-dynamics / rpops

PoPS (Pest or Pathogen Spread) R Package
https://ncsu-landscape-dynamics.github.io/rpops/
GNU General Public License v3.0
10 stars 5 forks source link

fixed multi metric calibrations #152

Closed ChrisJones687 closed 1 year ago

ChrisJones687 commented 1 year ago

This fixes 2 issues:

  1. Expected behavior is that once one success metric doesn't meet the criteria that parameter set isn't kept. The previous implementation had a check further down the line that passed overwrite another earlier failing test. This is now fixed.
  2. 3 parameters in the MCMC calibration had their tests reversed. This is also fixed.
codecov[bot] commented 1 year ago

Codecov Report

Base: 84.65% // Head: 85.13% // Increases project coverage by +0.47% :tada:

Coverage data is based on head (9a16936) compared to base (8a2f00a). Patch coverage: 78.57% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ========================================== + Coverage 84.65% 85.13% +0.47% ========================================== Files 46 46 Lines 5025 5112 +87 ========================================== + Hits 4254 4352 +98 + Misses 771 760 -11 ``` | [Impacted Files](https://codecov.io/gh/ncsu-landscape-dynamics/rpops/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncsu-landscape-dynamics) | Coverage Δ | | |---|---|---| | [R/calibrate.R](https://codecov.io/gh/ncsu-landscape-dynamics/rpops/pull/152/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncsu-landscape-dynamics#diff-Ui9jYWxpYnJhdGUuUg==) | `84.14% <73.17%> (+1.51%)` | :arrow_up: | | [R/helpers.R](https://codecov.io/gh/ncsu-landscape-dynamics/rpops/pull/152/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncsu-landscape-dynamics#diff-Ui9oZWxwZXJzLlI=) | `77.27% <100.00%> (+2.54%)` | :arrow_up: | | [inst/include/simulation.hpp](https://codecov.io/gh/ncsu-landscape-dynamics/rpops/pull/152/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncsu-landscape-dynamics#diff-aW5zdC9pbmNsdWRlL3NpbXVsYXRpb24uaHBw) | `88.23% <0.00%> (+1.56%)` | :arrow_up: | | [R/quantity\_allocation\_disagreement.R](https://codecov.io/gh/ncsu-landscape-dynamics/rpops/pull/152/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncsu-landscape-dynamics#diff-Ui9xdWFudGl0eV9hbGxvY2F0aW9uX2Rpc2FncmVlbWVudC5S) | `90.18% <0.00%> (+2.45%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncsu-landscape-dynamics). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncsu-landscape-dynamics)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.