ncsu-landscape-dynamics / rpops

PoPS (Pest or Pathogen Spread) R Package
https://ncsu-landscape-dynamics.github.io/rpops/
GNU General Public License v3.0
10 stars 5 forks source link

CI: Fix R version specification #81

Closed wenzeslaus closed 3 years ago

wenzeslaus commented 3 years ago

The R version should be specified for r-lib/actions/setup-r, not actions/checkout. This moves the with item to the right step.

wenzeslaus commented 3 years ago

The errors for 3efdc31 are what I get when I run devtools::check() locally. It is potentially just formal (Error: unused arguments (fun = function(x)...) and related to terra::as.points(...).

══ Skipped tests ═══════════════════════════════════════════════════════════════
● empty test (1)

══ Failed tests ════════════════════════════════════════════════════════════════
── Error (test-calibrate.R:78:13): ABC calibration has correctly formatted returns with multiple output
          comparisons ──
Error: Error: unused arguments (fun = function (x) 
{
    x > 0
}, spatial = TRUE)
Backtrace:
    █
 1. └─PoPS::calibrate(...) test-calibrate.R:78:12
 2.   └─PoPS::configuration(config)
 3.     ├─terra::as.points(...)
 4.     └─terra::as.points(...)
── Error (test-calibrate.R:229:13): ABC calibration has correctly formatted returns with multiple output
          comparisons ──
Error: Error: unused arguments (fun = function (x) 
{
    x > 0
}, spatial = TRUE)
Backtrace:
    █
 1. └─PoPS::calibrate(...) test-calibrate.R:229:12
 2.   └─PoPS::configuration(config)
 3.     ├─terra::as.points(...)
 4.     └─terra::as.points(...)
...
 Error: Error: unused arguments (fun = function (x) 
{
    x > 0
}, spatial = TRUE)
Backtrace:
    █
 1. └─PoPS::validate(...) test-validate.R:242:4
 2.   └─PoPS::configuration(config)
 3.     ├─terra::as.points(...)
 4.     └─terra::as.points(...)

[ FAIL 27 | WARN 0 | SKIP 1 | PASS 152 ]
ChrisJones687 commented 3 years ago

Merging this as it won't affect installation and this is the proper way to set up the CI. Good catch