search

ncsu-landscape-dynamics / rpops

PoPS (Pest or Pathogen Spread) R Package
https://ncsu-landscape-dynamics.github.io/rpops/
GNU General Public License v3.0
10 stars 5 forks source link

fix length check of terra object #86

Closed nkruskamp closed 3 years ago

nkruskamp commented 3 years ago

It appears the check was against the length of the file name string, not the number of layers of the terra raster object.

codecov[bot] commented 3 years ago

Codecov Report

Merging #86 (a058bad) into master (4600da2) will increase coverage by 0.16%. The diff coverage is 100.00%.

:exclamation: Current head a058bad differs from pull request most recent head a3fc786. Consider uploading reports for the commit a3fc786 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   75.17%   75.34%   +0.16%     
==========================================
  Files          39       39              
  Lines        4589     4591       +2     
==========================================
+ Hits         3450     3459       +9     
+ Misses       1139     1132       -7
Impacted Files Coverage Δ
R/checks.R 78.97% <100.00%> (+0.07%) :arrow_up:
R/quantity_allocation_disagreement.R 92.30% <0.00%> (+5.98%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4600da2...a3fc786. Read the comment docs.

ChrisJones687 commented 3 years ago

It appears the check was against the length of the file name string, not the number of layers of the terra raster object.

This is by design. It is comparing the length of the number of files to the length of the number of dates. Each date has a separate file,