search

ncsu-landscape-dynamics / rpops

PoPS (Pest or Pathogen Spread) R Package
https://ncsu-landscape-dynamics.github.io/rpops/
GNU General Public License v3.0
10 stars 5 forks source link

auto_manage function needs better variable handling #87

Closed wenzeslaus closed 1 year ago

wenzeslaus commented 3 years ago

Here are two possibly related problems with auto_manage code:

  1. R CMD check reports possible problems for the auto_manage function. Here are the results:
checking R code for possible problems ... NOTE
  auto_manage: no visible binding for global variable ‘infected’
  auto_manage: no visible global function definition for ‘stack’
  auto_manage: no visible binding for global variable ‘host’
  auto_manage: no visible global function definition for ‘nlayers’
  auto_manage: no visible binding for global variable ‘num_cells’
  auto_manage: no visible binding for global variable ‘buffer_cells’
  auto_manage: no visible binding for global variable ‘random_seeds’
  auto_manage: no visible binding for global variable ‘exposed’
  auto_manage: no visible binding for global variable ‘total_populations’
  auto_manage: no visible binding for global variable ‘mortality_tracker’
  auto_manage: no visible binding for global variable ‘mortality’
  auto_manage: no visible binding for global variable ‘quarantine_areas’
  1. Function is ignoring config or needs some explanation: The auto_manage function takes parameters, adds them to config list, but then config is not used to set parameters in the pops_model call. If this is an intention, it should be documented in a comment. If not, it should be fixed.
ChrisJones687 commented 1 year ago

Removed this function as it is unused.