search

ncsurobotics / seawolf

Seawolf Software Platform
http://www.ncsurobotics.com/
6 stars 5 forks source link

Separate movement control (sw3) from navigation logic (mission_control) #18

Closed dralley closed 10 years ago

dralley commented 10 years ago

This is up for debate, but mission_control should mostly be high-level logic regarding navigation. sw3 would be better off as a standalone module called 'movement' or something. I can refactor it in experimental branch if nobody has any objections.

Additionally, data.py is all IMU sensor data, it doesn't really belong in either.

mrwiggin commented 10 years ago

Let's not do that until we can meet and discuss it. Mission control code includes a lot of navigation commands (sw3). And if we were going to create an sw3(or just sw) module, we should decide on how we want to split up the software, it may be better to split it up into more modules.

This is up for debate, but mission_control should mostly be high-level logic regarding navigation. sw3 would be better off as a standalone module called 'movement' or something. I can refactor it in experimental branch if nobody has any objections.

Additionally, data.py is all IMU sensor data, it doesn't really belong in either.

— Reply to this email directly or view it on GitHub https://github.com/ncsurobotics/seawolf5/issues/18.

dralley commented 10 years ago

Yeah that was what I was wondering. It would be a pretty substantial refactor.

We'll leave it as-is for now. Any structural changes can be done in the new Seawolf framework.