search

ncuesta / dropzonejs-rails

Spice your Rails apps with some Dropzone sugar!
http://rubygems.org/gems/dropzonejs-rails
MIT License
312 stars 56 forks source link

Updates Dropzone to its 4.0.0 version #24

Closed ncuesta closed 9 years ago

ncuesta commented 9 years ago

Also changes the logic of the Rakefile to adapt itself to the changes introduced in the library's dist code layout.

ncuesta commented 9 years ago

/cc @Dinuz: can you please test this branch before I merge it in and provide some feedback?

Dinuz commented 9 years ago

@ncuesta absolutely!

I am going to do it in a couple of hours...ok?

ncuesta commented 9 years ago

@Dinuz great! Didn't expect such a timely response, so take your time :bow:

Dinuz commented 9 years ago

@ncuesta are we in the same side of the world? lol

Dinuz commented 9 years ago

@ncuesta well I tested the branch, and it seems working fine. I mean i bundle installed it without any issue and I included js and scss with @import without problem.

I didn't use yet the code (as I didn't use the library at all...I am tweaking some backend image processing on my app, and I should be able to pull out the front end I believe tomorrow).

If you want that I fully test also the js please wait another couple of days before merging.

I don't think there should be problems anyway, just because your gem only bring the dropzone assets in the pipeline. If any other issue exists, probably it's just related with the library.

ncuesta commented 9 years ago

Awesome @Dinuz! Thanks for being the guinea pig for this release :)

I'll merge it in, and if anything should fail, we'll fix it on 0.7.1.

Kudos to you!