search

ncuesta / dropzonejs-rails

Spice your Rails apps with some Dropzone sugar!
http://rubygems.org/gems/dropzonejs-rails
MIT License
312 stars 56 forks source link

replace image-path with image-url #3

Closed ginter closed 11 years ago

ginter commented 11 years ago

the image-path helper doesn't generate the correct css for displaying the images. I had to use image-url.

ncuesta commented 11 years ago

Can you please provide some more details into this change? Thanks!

On Monday, April 29, 2013, Chris wrote:

the image-path helper doesn't generate the correct css for displaying the

images. I had to use image-url.

You can merge this Pull Request by running

git pull https://github.com/ginter/dropzonejs-rails master

Or view, comment on, or merge it at:

https://github.com/ncuesta/dropzonejs-rails/pull/3 Commit Summary

  • Update dropzone.css.scss

File Changes

  • M vendor/assets/stylesheets/dropzone/dropzone.css.scsshttps://github.com/ncuesta/dropzonejs-rails/pull/3/files#diff-0(12)

Patch Links:

José Nahuel Cuesta Luengo nahuelcuestaluengo@gmail.com

ginter commented 11 years ago

When I was trying to integrate it none of my images were working. I checked the generated CSS and instead of something like "background: url(http://...)" it was just giving "background: http://" leaving off the "url" portion. When I switched to image-url it fixed it.

ncuesta commented 11 years ago

I'm merging it, but I'll look deeper into this, it doesn't feel completely right to me at the moment.

Thanks!