ncuesta / dropzonejs-rails

Spice your Rails apps with some Dropzone sugar!
http://rubygems.org/gems/dropzonejs-rails
MIT License
311 stars 56 forks source link

Update dropzone rake tasks #41

Closed thomasstephane closed 7 years ago

thomasstephane commented 7 years ago

Hi there,

I was checking if there is a new version of dropzone.js available and was thrown off by the fact that the check rake task was raising an error because there is no new version. So I changed it to abort. While doing that I noticed that check was also updating the version, which felt slightly out of place because if one doesn't want to replace with the new version, it still bumps the version, so I moved that to... a thing led to another, I refactored to the below, which basically:

I hope that's ok to suggest these changes, feedback welcome.

thomasstephane commented 7 years ago

Thanks @ncuesta , comment addressed, good point 👍

I think it's probably better to keep minor version bump, although following dropzonejs version has a nice ring to it, it feels like it might not always align nicely, and we'd have to account for bump of multi versions at once (say if this gem misses one minor and one major update before the next one, should we bump once or twice?).

So I vote for minor update the way you had it before if that works for you

thomasstephane commented 7 years ago

Thanks @ncuesta , glad I can help!