search

ncuillery / angular-breadcrumb

Generate a breadcrumb from ui-router's states
http://ncuillery.github.io/angular-breadcrumb/
MIT License
785 stars 183 forks source link

ncyBreadcrumbLabel can be build by text or function #136

Open Krolock1 opened 8 years ago

Krolock1 commented 8 years ago

with this extention it is possible to define the label of the breadcrumb as string or as callback function that is called with with viewScope as parameter. The behaviour is similar to the 'parent' parameter

ncuillery commented 8 years ago

Hi, many thanks for the PR.

At first glance, it looks good to me. I can't merge it for the moment: I need to fix tests (https://github.com/ncuillery/angular-breadcrumb/issues/135) before.

Then I'll test this stuff.

ravikiranr26 commented 8 years ago

Hi, Is this updated to the plugin ? can we use label function like parent ?

ncuillery commented 8 years ago

Hi @Krolock1, can you rebase your PR please ? Tests should be working.

Krolock1 commented 8 years ago

It's my first time that I will do a rebase, so I have to look how to do. Since the week is very busy I will do it next week

stramel commented 8 years ago

Seems related to #105 #146

javoire commented 8 years ago

I like this, it looks good to me too. Would be awesome if it got merged.