ncuillery / angular-breadcrumb

Generate a breadcrumb from ui-router's states
http://ncuillery.github.io/angular-breadcrumb/
MIT License
785 stars 183 forks source link

Loss of context in breadcrumb labels #176

Open YuriMasyanISS opened 7 years ago

YuriMasyanISS commented 7 years ago

here's my Plunk: http://plnkr.co/edit/8m2kpi8mtr9jTLF5wI00?p=preview

I have two sibbling (for ui-router) states (state1 and state2).

In state2: ncyBreadcrumb: parent: 'state1'

Both have similar labels: ncyBreadcrumb: label: '{{label}}'

They have similar controllers like: controller: function ($scope) {$scope.label = 'label 1'} and controller: function ($scope) {$scope.label = 'label 2'}

According to API-Reference:

The property ncyBreadcrumbLabel can contains bindings which are evaluated against the scope of the current state controller. For example, this state's config ...

I see that bindings of both ncyBreadcrumbLabel in "step in steps" are corresponding to the same last controller in chain. Isn't each scope in breadcrumb step supposed to refer to the state controller it was defined in? Can i define each label in its own state dynamically, so that it would be properly displayed no matter its sorrounding is?

ps.: i also noticed it's extremely easy to shutdown browser by assignment to state2: ncyBreadcrumb: parent: state2 with no error in console

nhim175 commented 7 years ago

I got the same issue