0.57.0

[erickzanardo]

Hello

0.57.0 was released 5 days ago opening this just for a reminder :)

[jgcmarins]

PRs are welcome \o/

[erickzanardo]

I would love to open a PR, but I guessed by reading this section of the README:

How can I contribute ?
Unfortunately you can't ;). Correct me if I'm wrong but due to the particular structure of the branch tree, it's impossible to collaborate in the classic way (Pull Request on a non-existing branch).

That it was not possible, any way to submit a PR?

[jgcmarins]

I've seen forks that submitted the diff before this repo.

[ryankask]

I’ve been trying to get the latest diffs out but I’ve been having issues. See #33.

If you push a branch to your fork and post a link here I will apply it.

There was a version 0.56.1 published so we need to get that out first.

On Mon, 17 Sep 2018 at 13:36, João Marins notifications@github.com wrote:

I've seen forks that submitted the diff before this repo.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ncuillery/rn-diff/issues/34#issuecomment-422104874, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE_45J6DNaG1gMsyqx4n6XS7mcwXdPbks5ub923gaJpZM4WsU6z .

-- Warm regards, Ryan Kaskel

[erickzanardo]

@ryankask thanks for the reply,

I had problems regarding upgrading RN from 0.56.0 to 0.56.1 too (like you said on #33), when I get home from work I will see if I can generate the diffs.

Thanks

[pvinis]

trying to see whats wrong with the upgrades

[pvinis]

i cant figure it out. i am tempted to create a new RNApp in 0.57.0 and then do a diff, to see. in fact, ill just do that now.

[pvinis]

i created a new diff, 0.55.4 -> 0.57.0, by creating a new project over the old one and getting the actual diff. i could not find a nice quick way to do all the steps. 0.55.4 was the last easy babel 6 version, and 0.57.0 is the first easy babel 7 version. i hope that is enough for people. shall i close this or do we need something more?

[erickzanardo]

What fixed the RN 0.56.0 upgrade for me was this

RN 0.56.0 seems to have some issues related to babel and I was not able to use it after the upgrade, only after updating that preset

[pvinis]

i saw comments like this, many with different versions of the babel preset, babel-core, @babel/core, metro etc. i thought that the cleanest most correct way is to recreate it. if other things worked, be my guest and upload them or make a pr, but for me the manual 57 is good.

[ryankask]

I think we should revert the latest README changes and delete the rn-0.57.0 branch and do 0.56.0 to 0.56.1 and then 0.56.1 to 0.57.0 manually.

It doesn't look like there were any changes which matches my fork's branches.

[pvinis]

for the last part, what do you mean? for the first part, sure it could be done, but I didn't want to spend any more time for upgrading my apps that were 0.55.4, so I made that one. feel free to make the other ones. :)

[ryankask]

Please ignore the second part.

It makes sense to do what works for you but I would do it on your fork. It's confusing because this project's README.md isn't consistent because of ee230cd:

[pvinis]

I agree that it's inconsistent. I could add like a '*' so it shows it's different and not a one step up.

[sibelius]

check this https://github.com/react-native-community/rncamera-example/pull/13

[kdawgwilk]

0.57.7 is out, I can't help but notice the repo is behind a few versions. Where do I start if I would like to help add the missing versions

[jgcmarins]

I am following this fork: https://github.com/pvinis/rn-diff-purge