search

ncvo / charity-commission-extract

Python utilities for handling the import of data from the Charity Commission data extract
43 stars 21 forks source link

Fix regression causing a value error #6

Open cal97g opened 5 years ago

cal97g commented 5 years ago

@marc-ncvo the issue was that bcp_filename is never defined.

It looks like a regression of #2 ? 454b60d0079b50e25812cb840c50f3b9b0b0ed1d ln 226

marc-ncvo commented 5 years ago

Thanks for your reply. The trouble is that those lines wouldn't be able to perform the check they need to. It might be better to add bcp_filename = None to line 229, so that when the check for the format of the file name isn't matched, we don't get an error when passing it to zf.read in line 234. For clarity, bcp_filename is defined in line 232, where it is assigned the value 'i'. Does this make sense to you?

cal97g commented 5 years ago

You're probably right @marc-ncvo - this fix worked for me I believe, I don't have any time to make amendments to this PR. Does the current version in master work for you?