nczempin / Turres-Monacorum

scifi tower defense made with löve2d and lua
http://nczempin.github.io/Turres-Monacorum/
Other
52 stars 10 forks source link

music looping issues #77

Open nczempin opened 10 years ago

nczempin commented 10 years ago

Right now we only have a maximum of 1 piece of music playing per "state" (such as "main menu"). When the track ends, it's supposed to seamlessly loop back to the beginning.

However, there seems to be a jump when this loop occurs.

Let's find out where this comes from, and eliminate it.

nczempin commented 10 years ago

I created a branch off a very early version of the project, https://github.com/nczempin/Turres-Monacorum/tree/soundtest. Just press "2" to start the music.

The gap is noticeable there, but if my memory serves me correctly, perhaps this gap is not as large as in the current master HEAD (https://github.com/nczempin/Turres-Monacorum/releases/tag/v0.6.2).

nczempin commented 10 years ago

I downloaded Audacity (http://audacity.sourceforge.net/download/) to check the audio file. If there is any gap then it is hardly noticeable. So @meriland, we can be fairly sure that the issue is not with the audio material.

However, the music file https://github.com/nczempin/Turres-Monacorum/blob/soundtest/sounds/Chiptune_2step_mp3.mp3 has an ever so slightly irregular rhythm.

To make sure that this is not fooling anyone's perception of any gaps, I'll look for (or create) a sound file with more regularity, that is also much shorter, so I don't have to listen a whole minute before the loop comes around.

nczempin commented 10 years ago

Okay, I created a shorter test loop in be14292138994e2144860e446e1835402f8b57bc. There seems to be no rhythmic gap (there is a volume mismatch so you get a slight click, but that is not the issue here).

nczempin commented 10 years ago

Playing loops of sound effects seems to work just fine.