pk1130
commented
3 years ago Apologies for the delay in implementing these changes. Currently a little busy with another research task. Will get to this later this week if that's ok? I read all the comments about the changes and agree with you @jplalor. Thanks for the detailed explanations. Now test_pairs_path and the evaluate function in cli.py make much more sense. I was updating the docs as you guys were explaining stuff, but looks like you already went ahead and updated the docs for evaluation as well. Thanks for that too @jplalor!
jplalor
Reference Issues/PRs
Contributes to issue #19.
What does this implement/fix? Explain your changes.
Fixed bug in Line 144 of
cli.py. Completed debugging and PR as requested in conversation of the same issue. Comments above respective lines explain the fixes.Any other comments? Anything else to-do?
Need to create test suite of unit/integration tests. @EntilZha @jplalor please take a look when you have some time. Will add unit/integration test when time permits. For now, the issue has been fixed. Comments and commit changes should show the error and what has been changed. Please let me know in case of any issues/suggestions/questions. Thanks!