ndabas / pico-setup-windows

Quickly get started with Raspberry Pi Pico/RP2040 on Windows
Apache License 2.0
299 stars 35 forks source link

RPi Pico Project Generator - NMAKE -> invalid option 'j' #17

Closed quizque closed 2 years ago

quizque commented 2 years ago

When trying to enable the "Run build after generation" feature inside of the Raspberry Pi Pico Project Generator all files are generated fine but when it tries to build, it generates an error and fails.

Heres the options I have selected python_iTbq7fUBtt

Here is the log of it generating just fine 356Ew2gONF

This is where the error occurs python_SFMpKLdVAX

Here is a link to the project it generated ProjectName2.zip

ndabas commented 2 years ago

This appears to be a bug with the Pico Project Generator and not this installer project. Please open an issue there.

A quick look shows that the problem is here: https://github.com/raspberrypi/pico-project-generator/blob/master/pico_project.py#L1179 -- makeCmd = 'nmake -j ' + str(cpus) -- nmake has no -j option. You could actually just submit a PR changing that line to makeCmd = 'nmake' which should fix it.

I'm closing this issue for now because there is nothing to do in this project.

JamesH65 commented 2 years ago

I've fixed this on the pico project generator master branch. Thanks for the diagnosis.

ndabas commented 2 years ago

@JamesH65 great, thank you!