search

ndarray / Boost.NumPy

Boost.Python interface for NumPy; now deprecated in factor of the version in Boost.Python itself.
Boost Software License 1.0
151 stars 73 forks source link

problem compiling with scons #40

Closed benbatya closed 9 years ago

benbatya commented 9 years ago

Hi there, I pulled the latest version of boost.numpy from github and tried to compile it with scons. It failed with an error: TypeError: cannot concatenate 'str' and 'NoneType' objects: File "/home/benjamin/Documents/Holo3D/external_libs/Boost.NumPy/SConstruct", line 21: setupTargets(env) File "/home/benjamin/Documents/Holo3D/external_libs/Boost.NumPy/SConscript", line 236: lib = SConscript(os.path.join(root, "libs", "numpy", "src", "SConscript"), exports='env') File "/usr/lib/scons/SCons/Script/SConscript.py", line 609: return method(_args, _kw) File "/usr/lib/scons/SCons/Script/SConscript.py", line 546: return _SConscript(self.fs, _files, _subst_kw) File "/usr/lib/scons/SCons/Script/SConscript.py", line 260: exec file in call_stack[-1].globals File "/home/benjamin/Documents/Holo3D/external_libs/Boost.NumPy/libs/numpy/src/SConscript", line 30: LIB_BOOST_NUMPY = ('boost_numpy' + LIB_SUFFIX)

I changed that line to: LIB_BOOST_NUMPY = ('boost_numpy' + EXT_SUFFIX)

and everything compiled fine.

Sorry, I don't have a diff to submit. The LIB_SUFFIX should probably be deleted. It's not used anymore

Cheers Ben

TallJimbo commented 9 years ago

Thanks for the bug report, and sorry for the extremely delayed response. I think this change has been made unnecessary by some other major changes to the SConscript files. If you disagree, please reopen.