Visual Studio compatibility fixes

ndarray / Boost.NumPy

Boost.Python interface for NumPy; now deprecated in factor of the version in Boost.Python itself.

Boost Software License 1.0

151 stars 73 forks source link

Closed willyd closed 8 years ago

willyd commented 9 years ago

Hi,

Here are some improvements for Visual Studio:

By default Visual Studio uses automatic linking. When using CMake this is undesirable since the CMake code links the libraries to the appropriate libraries using target_link_libraries. Adding add_definitions( -DBOOST_ALL_NO_LIB ) fixes this
If the user specifies we should use static boost libraries we need to specify -DBOOST_PYTHON_STATIC_LIB as the default is to use dynamic linking.

TallJimbo commented 8 years ago

Thanks, and sorry for the delay in merging!