search

ndbroadbent / turbo-sprockets-rails3

Speeds up your Rails 3 assets:precompile by only recompiling changed files, and only compiling once to generate all assets
MIT License
975 stars 78 forks source link

Add stub support #62

Closed aaronjensen closed 10 years ago

aaronjensen commented 11 years ago

stub was added in 2.2.0. It took me a while to figure out why it wasn't working when I realized it was effectively monkey patched out by turbo-sprockets-rails3. This adds it back in and bumps up the sprockets version dependency (which I realize may not be something you want to do). We could always detect support for it and optionally perform the stub removal.

tim-vandecasteele commented 11 years ago

Any reason why this is not taken along?

ndbroadbent commented 11 years ago

Not sure how this affects compatibility with other versions of Rails 3.2. I think 3-2-stable is pegged to a lower version of sprockets, IIRC. Maybe the optional stub removal would be a better idea in that case.

aaronjensen commented 11 years ago

No, it's pegged to 2.2.1: https://github.com/rails/rails/blob/3-2-stable/actionpack/actionpack.gemspec#L29

aaronjensen commented 11 years ago

Regardless, I bumped the version in the turbo-sprockets-rails3 gemspec so people on older sprockets could still use the older version.

romanbsd commented 10 years ago

Took me a while to understand, why my CSS is screwed up. This feature is absolutely required...

ndbroadbent commented 10 years ago

Sorry for the huge delay, merged and pushed 0.3.11 to rubygems

romanbsd commented 10 years ago

Awesome! :+1:

ndbroadbent commented 10 years ago

Please do let me know if you have any problems after updating

On Sun, Dec 8, 2013 at 1:18 PM, Roman Shterenzon notifications@github.comwrote:

Awesome! [image: :+1:]

— Reply to this email directly or view it on GitHubhttps://github.com/ndbroadbent/turbo-sprockets-rails3/pull/62#issuecomment-30093128 .