search

ndcn / omicser

The NDCN omics browser app for browsing and sharing general omics data.
https://ndcn.github.io/omicser
Other
3 stars 3 forks source link

rationalize config / options.yml #97

Closed ergonyc closed 2 years ago

ergonyc commented 2 years ago

I think "browser_config.yml" (from omicser_options.yml) and "db_config.yml"

are probably sensible... they are most correctly "config"urations. but is it confusing to have two types of configs?

k8hertweck commented 2 years ago

I like the names you're proposing. The way I've written the vignettes specifies two separate configurations, and it makes sense to me. Let me know if you update the code and I'll update the vignettes.

ergonyc commented 2 years ago

I will make the change this weekend. as I work through what's needed with the

  1. UI simplificiation/changes and
  2. interactivity in the ingestor Tab 3. renv encapsulation.. (might not need to deal with python environments at all! still testing)

Next week for scrubbing the documentation.

ergonyc commented 2 years ago

This is 90% complete... DONE:

TODO: