ndd7xv / heh

A terminal UI to edit bytes by the nibble.
MIT License
434 stars 18 forks source link

feat: support search by hex #131

Closed orhun closed 3 weeks ago

orhun commented 3 weeks ago

quick stab at #129

rec_20240608T224828

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 20.4%. Comparing base (b3cecaf) to head (6eedba8).

Additional details and impacted files | [Files](https://app.codecov.io/gh/ndd7xv/heh/pull/131?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nathan) | Coverage Δ | | |---|---|---| | [src/app.rs](https://app.codecov.io/gh/ndd7xv/heh/pull/131?src=pr&el=tree&filepath=src%2Fapp.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nathan#diff-c3JjL2FwcC5ycw==) | `0.0% <0.0%> (ø)` | |
orhun commented 3 weeks ago

Thanks for the insight, @ndd7xv. I was semi-aware of that feature but didn't know its details.

I think we should remove all the code related to the 0x format

Yeah, I agree.

If the change is not in this PR, I'll create an issue for it.

Please go for it, I can also pick that up and work on it!

perhaps we should wait to see what the user who created the issue thinks?

Yup, I'm mainly waiting for some feedback, then we can go with this!

ndd7xv commented 3 weeks ago

Seems like it's good from the reporter's side, so feel free to merge (or I can do it if you want)! I've also created https://github.com/ndd7xv/heh/issues/133 to remove what I mentioned in my earlier comment.

I really appreciate all the help you've provided to heh :D