ndd7xv / heh

A terminal UI to edit bytes by the nibble.
MIT License
444 stars 18 forks source link

Implemented endianness switch #53

Closed JungleTryne closed 1 year ago

JungleTryne commented 1 year ago

Fixes #15 Now with CTRL+e one can switch endianness in the editor. The notification about it will pop up once the user uses the hotkey

ndd7xv commented 1 year ago

Thanks so much for the PR! This is especially nice since the issue was created externally :D

I'll try and review it in the coming days :)

codecov[bot] commented 1 year ago

Codecov Report

Merging #53 (5fdbca6) into main (3036b4d) will decrease coverage by 0.4%. The diff coverage is 0.0%.

Additional details and impacted files | [Impacted Files](https://codecov.io/gh/ndd7xv/heh/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/input.rs](https://codecov.io/gh/ndd7xv/heh/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2lucHV0LnJz) | `0.0% <0.0%> (ø)` | | | [src/label.rs](https://codecov.io/gh/ndd7xv/heh/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xhYmVsLnJz) | `0.0% <0.0%> (ø)` | | | [src/main.rs](https://codecov.io/gh/ndd7xv/heh/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL21haW4ucnM=) | `3.5% <ø> (ø)` | |
ndd7xv commented 1 year ago

This looks great! I'm thinking that in the future, I'll find some way to refactor the entire label file, but currently don't how else endianness would be implemented with how label.rs it exists now (sorry about the messiness).

One nitpick - would it be OK if we changed the format statements as suggested by clippy?

https://github.com/ndd7xv/heh/actions/runs/4622352159/jobs/8198035205#step:4:210

JungleTryne commented 1 year ago

Sure thing! I've fixed it, now clippy shouldn't generate those errors

ndd7xv commented 1 year ago

Thanks so much! Merging now :)