Closed JungleTryne closed 1 year ago
Thanks so much for the PR! This is especially nice since the issue was created externally :D
I'll try and review it in the coming days :)
Merging #53 (5fdbca6) into main (3036b4d) will decrease coverage by
0.4%
. The diff coverage is0.0%
.
This looks great! I'm thinking that in the future, I'll find some way to refactor the entire label file, but currently don't how else endianness would be implemented with how label.rs it exists now (sorry about the messiness).
One nitpick - would it be OK if we changed the format
statements as suggested by clippy?
https://github.com/ndd7xv/heh/actions/runs/4622352159/jobs/8198035205#step:4:210
Sure thing! I've fixed it, now clippy shouldn't generate those errors
Thanks so much! Merging now :)
Fixes #15 Now with
CTRL+e
one can switch endianness in the editor. The notification about it will pop up once the user uses the hotkey